Bug fix related to monster spawning #2374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as monsters not being properly deleted)
|
Thanks for tracking this down 👍 |
AJenbo
approved these changes
Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the bug mentioned here: #2280 (reply in thread)
The cause was the refactor to DeleteMonster() here: 71241d1#diff-d46585089d315b53630b1035442b3d490d7b422cb05ceee76cf9041de3e39179R1235
With the two values not swapped, then values in ActiveMonsters after ActiveMonsterCount could have the same id as alive monsters, thus monsters being spawned (ie, by the skeleton king) could overwrite alive monsters and all kinds of funky stuff happened.