API: Adds DeletePrefixes #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cicoyle
reviewed
Sep 3, 2024
cicoyle
reviewed
Sep 3, 2024
cicoyle
reviewed
Sep 3, 2024
cicoyle
approved these changes
Sep 3, 2024
artursouza
approved these changes
Sep 4, 2024
artursouza
requested changes
Sep 4, 2024
|
This change is too big for a patch. We can release 0.3 |
|
@artursouza makes sense- I have opened this PR to fast forward master to keep up with release-0.2 |
Adds a new DeletePrefixes API which deletes all jobs (as well as counters) whose names match the given prefixes. Note the given strings to this API are prefixes of the _job names_, not the underlying ETCD keys. Prefixes will be serialized into the actual ETCD keys. This is useful for Dapr to add a feature whereby jobs (of all of types) in a particular namespace (some job prefix) are deleted when a Kubernetes Namespace is deleted. Moves `/internal/tests` to `/tests` to expose cron ETCD helper funcs for library consumers. Expands package with a `cron` sub-package to introduce single and clustered cron server setup helpers. Exposes the `CounterGarbageCollectionInterval` time duration pointer option to enable testing time interval triggered counter garbage collection. This is set to a low value during some tests, which has a side effect of soft testing this doesn't prematurely delete counters. Slight refactor of `api_test.go` to reside in a different package to prevent a circular import from `/tests`. Adds `/fake` for exposing a fake cron that library consumers can use for testing. Signed-off-by: joshvanl <me@joshvanl.dev>
JoshVanL
force-pushed
the
api-deleteprefixes
branch
from
5173b93 to
06d2c01
Compare
artursouza
approved these changes
Sep 5, 2024
artursouza
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new DeletePrefixes API which deletes all jobs (as well as counters) whose names match the given prefixes. Note the given strings to this API are prefixes of the job names, not the underlying ETCD keys. Prefixes will be serialized into the actual ETCD keys.
This is useful for Dapr to add a feature whereby jobs (of all of types) in a particular namespace (some job prefix) are deleted when a Kubernetes Namespace is deleted.
Moves
/internal/teststo/teststo expose cron ETCD helper funcs for library consumers. Expands package with acronsub-package to introduce single and clustered cron server setup helpers.Exposes the
CounterGarbageCollectionIntervaltime duration pointer option to enable testing time interval triggered counter garbage collection. This is set to a low value during some tests, which has a side effect of soft testing this doesn't prematurely delete counters.Slight refactor of
api_test.goto reside in a different package to prevent a circular import from/tests.Adds
/fakefor exposing a fake cron that library consumers can use for testing.