Add instance variable which holds line in which errors happen #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Thanks for the PR. Looks like the Travis CI integration no longer works, would you be able to resolve #75? |
|
I don't believe I have the permissions to do so and I haven't used github actions before but I could give it a try |
Merged
|
Let's keep these as separate PRs |
|
@santilytics Thanks! Released in https://pypi.org/project/vladiate/0.0.24/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply adds the Line number as an instance variable. The test coverage piggy backs from existing tests to show the line numbers are correct.
Using a set ensures no line errors are repeated even if multiple validators find errors in the same line.
Would you like to add the line number to the error log? If so, where do you consider is the best place to be added if at all?