Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be a little less strict on invalid frames #14

Merged
merged 1 commit into from
Jul 12, 2015
Merged

Conversation

xhenner
Copy link
Contributor

@xhenner xhenner commented Jul 5, 2015

The patch db723fe is a little too strict and I end up having files with missing tag.
The main cause was the iTunes specific tags.

I tweaked the validity check to just ignore unknown frame and try to continue the parsing if possible.

On a side note, the year() API call is broken in the current state, since the
func (f frameNames) Name() method use the same frame names for 2.3 and 2.4 BUT in 2.4 TYER is replaced by the TDRC frame

And, to complicate things, some software still use 2.4 frames in 2.3 tagging (for example Musicbrainz Picard use TSOP frame in 2.3 tagging)

I propose to make the following change :

  1. merge the validity list for 2.4 and 2.3. It will assure a better compatibility with strange tagger
  2. change the logic of the Name() method to use TDRC if present, TYER if not (or maybe prefer the TORY to TYER ?)

@xhenner xhenner force-pushed the itunes branch 3 times, most recently from 4bfdc30 to 1e60a81 Compare July 5, 2015 21:49
@xhenner
Copy link
Contributor Author

xhenner commented Jul 5, 2015

I change my mind of the patch and try to parse any unknown frame anyway.
To be honest, I need to do this for my write patch which needs me to track all the frames, even the proprietary one. I can squash the 2 commits if you want

@dhowden
Copy link
Owner

dhowden commented Jul 11, 2015

Sorry for the delay! Yes, please merge the two commits into one, and then I'll merge it in.

@xhenner
Copy link
Contributor Author

xhenner commented Jul 11, 2015

done

@dhowden
Copy link
Owner

dhowden commented Jul 11, 2015

You also need to run go fmt on that too (sorry - forgot to mention that).

Add iTunes frames and ignore unknown frame only if they are too big
@xhenner
Copy link
Contributor Author

xhenner commented Jul 12, 2015

my bad
reformatted

dhowden added a commit that referenced this pull request Jul 12, 2015
Be a little less strict on invalid frames
@dhowden dhowden merged commit 549eab9 into dhowden:master Jul 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants