feat: add dynamic payload support in schema controller #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amarts
approved these changes
Sep 25, 2024
| return res.status(400).json({ error: validationError }); | ||
| } | ||
|
|
||
| data = extractSchemaFields(data) |
There was a problem hiding this comment.
do you want to take it as a separate variable?
It may help in debug and other reasons later.
There was a problem hiding this comment.
If I treat it as a separate variable, I will encounter a type error when passing it to the buildFromProperties function, indicating that the following properties are missing from the type 'ISchema': $id, $schema
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the ability for the schema controller in the Issuer Agent to handle dynamic payloads. This means the API can now work with different types of data sent in requests. Currently, the API only accepts the expected request payload and directly passes it to SDK functions, which can throw errors if the payload format doesn't match.
In this PR, validation has been added to extract only the necessary fields before passing them to the function. Now, the API can accept different JSON formats while still extracting the required fields. Additionally, an interface for properties has been created to align with the Cord SDK