Merge branch 'develop'

Cargo.toml

@@ -17,6 +17,7 @@ members = [
 	"node/testing",
 	"pallets/asset",
 	"pallets/chain-space",
+	"pallets/namespace",
 	"pallets/did",
 	"pallets/did-name",
 	"pallets/identity",
@@ -898,6 +899,7 @@ pallet-registries = { path = "pallets/registries", default-features = false }
 pallet-entries = { path = "pallets/entries", default-features = false }
 pallet-schema-accounts = { path = "pallets/schema-accounts", default-features = false }
 pallet-meta-tx = { path = "pallets/meta-tx", default-features = false }
+pallet-namespace = { path = 'pallets/namespace', default-features = false }
 
 
 [profile.release]

README.md

@@ -208,13 +208,40 @@ If you would like to contribute, please fork the repository, follow the [contrib
 
 ### Before submitting the PR
 
-There are 3 tests which run as part of PR validation.
+There are 4 tests which run as part of PR validation.
 
-- Build - `cargo build --release`
+- #### Cargo Format 
+
+  Ensures the code format is in accordance with official Rust guidelines. Add the formatted files as part of the commit.
 
-- Clippy - `cargo clippy --all --no-deps --all-targets --features=runtime-benchmarks -- -D warnings`
+  ```bash 
+  cargo +nightly fmt --all
+  ```
+
+- #### Build 
+
+  Transform CORD codebase into executable binary.
+
+  ```bash 
+  cargo build --release
+  ```
+
+- Clippy 
+
+  Runs the linter to maintain clean and idiomatic code.
+
+  ```bash 
+  cargo clippy --all --no-deps --all-targets --features=runtime-benchmarks -- -D warnings`
+  ```
+
+- Test 
+
+  Runs CORD Network unit tests, integration tests and benchmarks defined for all modules.
+
+  ```bash
+  cargo test --release  --locked --features=runtime-benchmarks --no-fail-fast --verbose --color always --all --all-targets
+  ```
 
-- Test - `cargo test --release  --locked --features=runtime-benchmarks --no-fail-fast --verbose --color always --all --all-targets`
 
 Note that each of these would take significant time to run, and hence, if you are working on a specific pallet, you can use `-p <pallet-name> --lib` instead of `--all`. That should be faster than normal full test locally.
 

pallets/asset/src/mock.rs

@@ -65,7 +65,7 @@ impl mock_origin::Config for Test {
 
 parameter_types! {
 	pub const MaxEncodedValueLength: u32 = 1_024;
-	pub const MaxAssetDistribution: u32 = u32::MAX;
+	pub const MaxAssetDistribution: u32 = 25;
 }
 
 impl Config for Test {

pallets/asset/src/tests.rs

@@ -1,5 +1,5 @@
 use super::*;
-use crate::mock::*;
+use crate::{mock::*, types::AssetIssuanceEntry, Error};
 use codec::Encode;
 use cord_utilities::mock::{mock_origin::DoubleOrigin, SubjectId};
 use frame_support::{assert_err, assert_ok, BoundedVec};
@@ -278,12 +278,15 @@ fn asset_unauthorized_operation_should_fail() {
 			authorization_id.clone()
 		));
 
-		assert_err!(Asset::issue(
-			DoubleOrigin(unauthorized_author.clone(), unauthorized_creator.clone()).into(), // Unauthorized author attempting the action
-			issue_entry.clone(),
-			issue_entry_digest,
-			unauthorized_authorization_id.clone()
-		), Error::<Test>::UnauthorizedOperation);
+		assert_err!(
+			Asset::issue(
+				DoubleOrigin(unauthorized_author.clone(), unauthorized_creator.clone()).into(), // Unauthorized author attempting the action
+				issue_entry.clone(),
+				issue_entry_digest,
+				unauthorized_authorization_id.clone()
+			),
+			Error::<Test>::UnauthorizedOperation
+		);
 
 		assert_ok!(Asset::issue(
 			DoubleOrigin(author.clone(), creator.clone()).into(),
@@ -292,29 +295,32 @@ fn asset_unauthorized_operation_should_fail() {
 			authorization_id.clone()
 		));
 
-		assert_err!(Asset::transfer(
-			DoubleOrigin(unauthorized_author.clone(), unauthorized_creator.clone()).into(),
-			transfer_entry.clone(),
-			transfer_entry_digest,
-		),
-		Error::<Test>::UnauthorizedOperation
+		assert_err!(
+			Asset::transfer(
+				DoubleOrigin(unauthorized_author.clone(), unauthorized_creator.clone()).into(),
+				transfer_entry.clone(),
+				transfer_entry_digest,
+			),
+			Error::<Test>::UnauthorizedOperation
 		);
 
-		assert_err!(Asset::transfer(
-			DoubleOrigin(author.clone(), creator.clone()).into(),
-			unauthorized_transfer_entry.clone(),
-			unauthorized_entry_digest,
-		),
-		Error::<Test>::UnauthorizedOperation
+		assert_err!(
+			Asset::transfer(
+				DoubleOrigin(author.clone(), creator.clone()).into(),
+				unauthorized_transfer_entry.clone(),
+				unauthorized_entry_digest,
+			),
+			Error::<Test>::UnauthorizedOperation
 		);
 
-		assert_err!(Asset::status_change(
-			DoubleOrigin(unauthorized_author.clone(), unauthorized_creator.clone()).into(),
-			asset_id.clone(),
-			Some(instance_id.clone()),
-			AssetStatusOf::INACTIVE
-		),
-		Error::<Test>::UnauthorizedOperation
+		assert_err!(
+			Asset::status_change(
+				DoubleOrigin(unauthorized_author.clone(), unauthorized_creator.clone()).into(),
+				asset_id.clone(),
+				Some(instance_id.clone()),
+				AssetStatusOf::INACTIVE
+			),
+			Error::<Test>::UnauthorizedOperation
 		);
 
 		assert_ok!(Asset::vc_create(
@@ -324,13 +330,14 @@ fn asset_unauthorized_operation_should_fail() {
 			authorization_id.clone()
 		));
 
-		assert_err!(Asset::vc_issue(
-			DoubleOrigin(unauthorized_author.clone(), unauthorized_creator.clone()).into(),
-			issue_entry.clone(),
-			issue_entry_digest,
-			unauthorized_authorization_id
-		),
-		Error::<Test>::UnauthorizedOperation
+		assert_err!(
+			Asset::vc_issue(
+				DoubleOrigin(unauthorized_author.clone(), unauthorized_creator.clone()).into(),
+				issue_entry.clone(),
+				issue_entry_digest,
+				unauthorized_authorization_id
+			),
+			Error::<Test>::UnauthorizedOperation
 		);
 
 		assert_ok!(Asset::vc_issue(
@@ -340,31 +347,33 @@ fn asset_unauthorized_operation_should_fail() {
 			authorization_id
 		));
 
-		assert_err!(Asset::vc_transfer(
-			DoubleOrigin(unauthorized_author.clone(), unauthorized_creator.clone()).into(),
-			transfer_entry.clone(),
-			transfer_entry_digest,
-		),
-		Error::<Test>::UnauthorizedOperation
+		assert_err!(
+			Asset::vc_transfer(
+				DoubleOrigin(unauthorized_author.clone(), unauthorized_creator.clone()).into(),
+				transfer_entry.clone(),
+				transfer_entry_digest,
+			),
+			Error::<Test>::UnauthorizedOperation
 		);
 
-		assert_err!(Asset::vc_transfer(
-			DoubleOrigin(author.clone(), creator.clone()).into(),
-			unauthorized_transfer_entry.clone(),
-			unauthorized_entry_digest,
-		),
-		Error::<Test>::UnauthorizedOperation
+		assert_err!(
+			Asset::vc_transfer(
+				DoubleOrigin(author.clone(), creator.clone()).into(),
+				unauthorized_transfer_entry.clone(),
+				unauthorized_entry_digest,
+			),
+			Error::<Test>::UnauthorizedOperation
 		);
 
-		assert_err!(Asset::vc_status_change(
-			DoubleOrigin(unauthorized_author.clone(), unauthorized_creator.clone()).into(),
-			asset_id.clone(),
-			Some(instance_id.clone()),
-			AssetStatusOf::INACTIVE
-		),
-		Error::<Test>::UnauthorizedOperation
+		assert_err!(
+			Asset::vc_status_change(
+				DoubleOrigin(unauthorized_author.clone(), unauthorized_creator.clone()).into(),
+				asset_id.clone(),
+				Some(instance_id.clone()),
+				AssetStatusOf::INACTIVE
+			),
+			Error::<Test>::UnauthorizedOperation
 		);
-
 	});
 }
 
@@ -3057,3 +3066,98 @@ fn asset_vc_status_change_with_wrong_asset_id_should_fail() {
 		);
 	});
 }
+
+#[test]
+fn asset_issue_should_fail_when_distribution_limit_exceeds() {
+	let creator = DID_00;
+	let author = ACCOUNT_00;
+	let capacity = 200u64;
+
+	let raw_space = [2u8; 256].to_vec();
+	let space_digest = <Test as frame_system::Config>::Hashing::hash(&raw_space.encode()[..]);
+	let space_id_digest = <Test as frame_system::Config>::Hashing::hash(
+		&[&space_digest.encode()[..], &creator.encode()[..]].concat()[..],
+	);
+	let space_id: SpaceIdOf = generate_space_id::<Test>(&space_id_digest);
+
+	let auth_digest = <Test as frame_system::Config>::Hashing::hash(
+		&[&space_id.encode()[..], &creator.encode()[..], &creator.encode()[..]].concat()[..],
+	);
+	let authorization_id: Ss58Identifier = generate_authorization_id::<Test>(&auth_digest);
+	let asset_desc = BoundedVec::try_from([72u8; 10].to_vec()).unwrap();
+	let asset_tag = BoundedVec::try_from([72u8; 10].to_vec()).unwrap();
+	let asset_meta = BoundedVec::try_from([72u8; 10].to_vec()).unwrap();
+	let asset_qty = 1000;
+	let asset_value = 10;
+	let asset_type = AssetTypeOf::MF;
+
+	let entry = AssetInputEntryOf::<Test> {
+		asset_desc,
+		asset_qty,
+		asset_type,
+		asset_value,
+		asset_tag,
+		asset_meta,
+	};
+
+	let digest = <Test as frame_system::Config>::Hashing::hash(&[&entry.encode()[..]].concat()[..]);
+
+	let issue_id_digest = <Test as frame_system::Config>::Hashing::hash(
+		&[&digest.encode()[..], &space_id.encode()[..], &creator.encode()[..]].concat()[..],
+	);
+
+	let asset_id: Ss58Identifier = generate_asset_id::<Test>(&issue_id_digest);
+
+	new_test_ext().execute_with(|| {
+		// Create and approve space
+		assert_ok!(Space::create(
+			DoubleOrigin(author.clone(), creator.clone()).into(),
+			space_digest,
+		));
+		assert_ok!(Space::approve(RawOrigin::Root.into(), space_id.clone(), capacity));
+		assert_ok!(Asset::create(
+			DoubleOrigin(author.clone(), creator.clone()).into(),
+			entry.clone(),
+			digest,
+			authorization_id.clone()
+		));
+
+		let max_distribution = <Test as Config>::MaxAssetDistribution::get();
+
+		for _ in 0..max_distribution {
+			let issuance_entry = AssetIssuanceEntry {
+				asset_id: asset_id.clone(),
+				asset_owner: creator.clone(),
+				asset_issuance_qty: Some(1),
+			};
+
+			let issuance_digest =
+				<Test as frame_system::Config>::Hashing::hash(&issuance_entry.encode()[..]);
+
+			assert_ok!(Asset::issue(
+				DoubleOrigin(author.clone(), creator.clone()).into(),
+				issuance_entry,
+				issuance_digest,
+				authorization_id.clone()
+			));
+		}
+		let exceeding_entry = AssetIssuanceEntry {
+			asset_id: asset_id.clone(),
+			asset_owner: creator.clone(),
+			asset_issuance_qty: Some(1),
+		};
+
+		let exceeding_digest =
+			<Test as frame_system::Config>::Hashing::hash(&exceeding_entry.encode()[..]);
+
+		assert_err!(
+			Asset::issue(
+				DoubleOrigin(author.clone(), creator.clone()).into(),
+				exceeding_entry,
+				exceeding_digest,
+				authorization_id.clone()
+			),
+			Error::<Test>::DistributionLimitExceeded
+		);
+	});
+}

pallets/entries/Cargo.toml

@@ -41,6 +41,7 @@ sp-core = { workspace = true }
 cord-utilities = { workspace = true }
 sp-keystore = { workspace = true }
 serde_json = { workspace = true }
+pallet-namespace = { workspace = true }
 pallet-registries = { workspace = true }
 pallet-schema-accounts = { workspace = true }
 
@@ -66,6 +67,7 @@ std = [
 	"sp-std/std",
 	"identifier/std",
 	"cord-utilities/std",
+	"pallet-namespace/std",
 	"pallet-registries/std",
 	"pallet-schema-accounts/std",
 ]
@@ -75,6 +77,7 @@ runtime-benchmarks = [
 	"frame-system/runtime-benchmarks",
 	"sp-runtime/runtime-benchmarks",
 	"cord-utilities/runtime-benchmarks",
+	"pallet-namespace/runtime-benchmarks",
 	"pallet-registries/runtime-benchmarks",
 	"pallet-schema-accounts/runtime-benchmarks",
 ]