DeDir: Add new pallet Decentralized Directory
#495
Conversation
Signed-off-by: Shreevatsa N <vatsa@dhiway.com>
vatsa287
requested review from
smohan-dw and
amarts
and removed request for
smohan-dw
pallets/dedir/src/lib.rs
Outdated
| #[pallet::weight({0})] | ||
| pub fn create_registry( | ||
| origin: OriginFor<T>, | ||
| registry_id: RegistryIdOf<T>, |
There was a problem hiding this comment.
Registry ID is an identifier that should be returned after a successful operation.
There was a problem hiding this comment.
As per earlier conversation identifier creation was passed onto app side.
Would move the logic here if required.
pallets/dedir/src/lib.rs
Outdated
| pub fn create_registry( | ||
| origin: OriginFor<T>, | ||
| registry_id: RegistryIdOf<T>, | ||
| attrs: Vec<(RegistryKeyIdOf<T>, RegistrySupportedTypeOf)>, |
There was a problem hiding this comment.
The registry entry attributes should also help to identify the lookup fields that should be used for creating entry identifiers
There was a problem hiding this comment.
With the discussion with @amarts previously if the identifier is available then the registry_entry attributes would be fetch able.
pallets/dedir/src/lib.rs
Outdated
| registry_id: RegistryIdOf<T>, | ||
| attrs: Vec<(RegistryKeyIdOf<T>, RegistrySupportedTypeOf)>, | ||
| // TODO: Use Runtime Constant for upper bound | ||
| additional_states: Option<BoundedVec<BoundedVec<u8, ConstU32<32>>, ConstU32<10>>>, |
There was a problem hiding this comment.
why can't this be enums? also why can't this be part of attrs?
There was a problem hiding this comment.
Ack.
As per newer design the states supported shall not be dynamic as implemented above but fixed to Active, Revoked, Draft which will become enum type.
So any custom state can be part of attrs itself.
| } | ||
| } | ||
|
|
||
| Registries::<T>::insert(®istry_id, registry); |
There was a problem hiding this comment.
Delegation/Ownership is not implemented in this version. Will do with next commit.
pallets/dedir/src/lib.rs
Outdated
| pub fn create_registry_entry( | ||
| origin: OriginFor<T>, | ||
| registry_id: RegistryIdOf<T>, | ||
| registry_entry_id: RegistryEntryIdOf<T>, |
There was a problem hiding this comment.
again registry_entry_id is the result of the operation
- Identifier management: Validation of ss58 and ident type on chain - State as enums: Make states as enums, dynamic states can be through attributes - Address review comments Signed-off-by: Shreevatsa N <vatsa@dhiway.com>
Signed-off-by: Shreevatsa N <vatsa@dhiway.com>
|
done with #504 |
A
v1implementation of DeDir - Decentralised Directory.create-registry,create-registry-entry,registry-entry-state-change.enumformat. Custom states will be fromattributes.Abandoned. Do not merge.