Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C4GT] Asset: Add tests for InvalidDigest #369

Open
3 tasks
vatsa287 opened this issue Mar 12, 2024 · 5 comments
Open
3 tasks

[C4GT] Asset: Add tests for InvalidDigest #369

vatsa287 opened this issue Mar 12, 2024 · 5 comments
Assignees
@Zapper9982
Labels
C4GT Community good first issue Good for newcomers

Comments

@vatsa287
Copy link
Member

vatsa287 commented Mar 12, 2024 •
edited
Loading

Description

Subtask under : cord-network/community#7

New testcase can be tested under cargo test -p pallet-asset after adding it in the code.

Goals

  • Add tests for InvalidDigest for pallet/asset

Expected Outcome

  • Test should assert for InvalidDigest being returned properly in all the possible calls.
  • If there are more than one function returning this error code, all of them should be validated either as one test case or as multiple test cases.

Acceptance Criteria

NA

Implementation Details

Look at other test cases, and add a test case for the same.
Ex: check method asset_create_should_succeed which validates creation of asset.

Mockups / Wireframes

NA

Product Name

CORD

Organization Name

Dhiway

Domain

Blockchain

Tech Skills Needed

Rust

Mentor(s)

@amarts @vatsa287

Complexity

[Medium]

Category

[Test]

Sub Category

[Beginner friendly]
@rising0raj
Copy link

hey @vatsa287 I would like to work on this . I have gone through the code base can you assign this to me if it is open??

@Sohajawdekar
Copy link

Hey @vatsa287 !
I am interested in contributing to this project and reviewed the prerequisites and code. Can you please assign this issue to me ?

Aloneking789 added a commit to Aloneking789/cord that referenced this issue Mar 25, 2024
@Aloneking789
types.rs
48cfc00 
We're creating a new test function asset_create_should_fail_invalid_digest.
We set up the necessary variables such as creator, author, capacity, etc.
We create an invalid_digest that will intentionally trigger the InvalidDigest error (e.g., an empty vector).
Fixes dhiway#369
@Aloneking789 Aloneking789 mentioned this issue Mar 25, 2024
Closed
@VedantKhairnar
Copy link

Hello @Sohajawdekar
Are you currently open to contributing to the issue?
If yes, pls respond or directly raise the PR.
Thanks.

@Zapper9982
Copy link

hello @vatsa287 can I try on this then ?

@Zapper9982
Copy link

@vatsa287 Hi ,it has come to my attention that the InvalidDigest Error hasn't been thrown as error in any function in lib.rs , do i need to create a situation where InvalidDigest is thrown in any function ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Zapper9982 Zapper9982

Labels
C4GT Community good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

types.rs Aloneking789/cord
5 participants
@VedantKhairnar @vatsa287 @rising0raj @Sohajawdekar @Zapper9982