Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C4GT] Network-Score: Add tests for 'InvalidRatingValue' #297

Closed
3 tasks
vatsa287 opened this issue Feb 5, 2024 · 5 comments
Closed
3 tasks

[C4GT] Network-Score: Add tests for 'InvalidRatingValue' #297

vatsa287 opened this issue Feb 5, 2024 · 5 comments
Assignees
Labels

Comments

@vatsa287
Copy link
Member

vatsa287 commented Feb 5, 2024

Description

Subtask under : cord-network/community#7

New testcase can be tested under cargo test -p pallet-network-score after adding it in the code.

Goals

  • Add tests for InvalidRatingValue for pallet/network-score

Expected Outcome

  • Test should assert for InvalidRatingValue being returned properly in all the possible calls.
  • If there are more than one function returning this error code, all of them should be validated either as one test case or as multiple test cases.

Acceptance Criteria

NA

Implementation Details

Look at other test cases, and add a test case for the same.
Ex: In pallets/network-membership check method test_duplicate_member_request which validates error code MembershipAlreadyAcquired

Mockups / Wireframes

NA


Product Name

CORD

Organization Name

Dhiway

Domain

Blockchain

Tech Skills Needed

Rust

Mentor(s)

@amarts

Complexity

[Agree]

Category

[Test]

Sub Category

[Beginner friendly]

@amarts amarts added the good first issue Good for newcomers label Feb 6, 2024
@Sanika-k-1317
Copy link

Hello @vatsa287
I am interested in contributing to this project. Can we please connect for further discussions and could you please asssign the ticket to me?

@heyhimansh
Copy link

Hi @vatsa287 ,
Could you assign me the task of adding tests for 'InvalidRatingValue' in the Network-Score project?

@VedantKhairnar
Copy link

Hello @Sanika-k-1317
Are you working on the issue?
Pls let us know if you need any assistance.
Thanks.

Meanwhile, @heyhimansh Are you interested in working on the issue?

@mrswastik-robot
Copy link
Contributor

hey @VedantKhairnar, I would love to work on this issue if no one is already working

@vatsa287
Copy link
Member Author

Closing as completed from PR
#507

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants