Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created new function prepareCreateSubSpaceExtrinsic() #206

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

kartikaysaxena
Copy link
Contributor

Fixes #200

Signed-off-by: Kartikay <kartikay_2101ce32@iitp.ac.in>
@kartikaysaxena
Copy link
Contributor Author

PTAL @vatsa287 @adi-a11y

Copy link
Member

@vatsa287 vatsa287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please declare prepare... function above dispatch.... function.

export async function prepareCreateSubSpaceExtrinsic(
chainSpace: IChainSpace,
authorAccount: CordKeyringPair,
count: number,
Copy link
Member

@vatsa287 vatsa287 Apr 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

count here refers to count of transactions permitted to be performed on the chain for the subspace.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, thanks for the review!

Signed-off-by: Kartikay <kartikay_2101ce32@iitp.ac.in>
@kartikaysaxena kartikaysaxena requested a review from vatsa287 April 22, 2024 08:41
Copy link
Member

@vatsa287 vatsa287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vatsa287 vatsa287 requested a review from amarts April 22, 2024 08:50
@amarts amarts merged commit dd30d5e into dhiway:develop Apr 29, 2024
1 check passed
@kartikaysaxena kartikaysaxena deleted the subspace-extrinsic branch April 29, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[C4GT] ChainSpace: Separate preparation of create subspace extrinsic from chain dispatch
3 participants