Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

companion - 0.9.0 #145

Merged
merged 2 commits into from
Dec 1, 2023
Merged

companion - 0.9.0 #145

merged 2 commits into from
Dec 1, 2023

Conversation

smohan-dw
Copy link
Member

@smohan-dw smohan-dw commented Dec 1, 2023

companion of dhiway/cord#256

Updates augument-api, and score module.

@smohan-dw smohan-dw requested a review from amarts December 1, 2023 07:44
@amarts
Copy link
Member

amarts commented Dec 1, 2023

@smohan-dw please check if the changes are OK now

@@ -9,7 +9,7 @@
"build": "yarn workspaces foreach -Apt --exclude '{root-workspace}' run build",
"build:docs": "typedoc --skipErrorChecking --theme default --out docs/api --tsconfig tsconfig.docs.json && touch docs/.nojekyll",
"bundle": "yarn workspace @cord.network/sdk run bundle",
"clean": "rimraf tests/dist && yarn workspaces foreach -p --exclude '{root-workspace}' run clean",
"clean": "rimraf tests/dist && yarn workspaces foreach -Ap --exclude '{root-workspace}' run clean",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is required in prepublish, publish, and publish-beta options too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, will send a separate PR for that

@amarts
Copy link
Member

amarts commented Dec 1, 2023

I pushed the previous change which had conflicts to https://github.com/amarts/cord.js/tree/sm-updates-0x3_v1 (for your reference if something got missed out).

Copy link
Member Author

@smohan-dw smohan-dw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amarts amarts merged commit 97205d2 into dhiway:develop Dec 1, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants