fix: always open popup with single click #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 12, 2021
martinkrulltott
approved these changes
Sep 13, 2021
dhis2-bot
added a commit
that referenced
this pull request
Sep 13, 2021
## [2.1.2](v2.1.1...v2.1.2) (2021-09-13) ### Bug Fixes * always open popup with single click ([#398](#398)) ([bd2b9ac](bd2b9ac))
|
🎉 This PR is included in version 2.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where it is not possible to open a new popup while another is open. You need to click twice, first to close the popup that is currently open, then to open a new one.
The problem is that the mapping library is calling the onClose handler of the previous popup when a new popup is created, even though the same popup is reused. The fix is to detach the onClose handler when the popup is created, and then attach it again afterwards.
After this PR opening popups are much quicker: