fix: sort columns using non case sensitive sort #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dhis2-maintenance-app-beta ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
flaminic
force-pushed
the
DHIS2-18512/sort-case-insensitive
branch
from
4afac53 to
572c4e4
Compare
Birkbjo
reviewed
Dec 16, 2024
| @@ -78,5 +78,5 @@ export const useSectionListSortOrder = () => { | |||
| export const useSortOrderQueryParams = () => { | |||
| const [sortOrder] = useSectionListSortOrder() | |||
|
|
|||
| return sortOrder ? formatSortOrderToString(sortOrder) : undefined | |||
| return sortOrder ? `${sortOrder[0]}:i${sortOrder[1]}` : undefined | |||
There was a problem hiding this comment.
Do we always want to enforce case insensitive sorts?
I guess the reason why you didn't update formatSortOrderToString is because that would affect the URL, and not just the value used for the API. Which makes sense, but I still think we should try to reuse formatSortOrderToString?
Eg. we could do something like
const formatSortOrderToString = (value: ParsedSortOrder, caseSensitive: boolean = false): string =>
`${value[0]}:${caseSensitive ? '': 'i'}${value[1]}`There was a problem hiding this comment.
I think so.
yes i though the url makes more sense with the asc and desc, which is also what the table uses, Sure, I can move it in there, probably having a variable called caseSensitive helps the understanding of what the i does so happy w that
Birkbjo
reviewed
Dec 16, 2024
| @@ -57,7 +61,11 @@ export const HeaderColumnsSortable = ({ | |||
| {headerColumns.map((headerColumn) => ( | |||
| <DataTableColumnHeader | |||
| sortDirection={getDataTableSortDirection(headerColumn)} | |||
| onSortIconClick={handleSortOrderChange} | |||
| onSortIconClick={ | |||
There was a problem hiding this comment.
Nice, I guess this fixes that prop-type error
dhis2-bot
added a commit
that referenced
this pull request
Dec 18, 2024
## [0.19.5](v0.19.4...v0.19.5) (2024-12-18) ### Bug Fixes * adjust form container styles ([6d60814](6d60814)) * adjust form footer styles ([1be5c38](1be5c38)) * adjust global background color ([6eab28e](6eab28e)) * adjust help and description texts ([ec05922](ec05922)) * adjust org unit row height, expand button ([7e5b7a7](7e5b7a7)) * adjust sidebar filter empty state ([dc1f21f](dc1f21f)) * adjust table icon button color ([fcfc1b5](fcfc1b5)) * data element group transfers sizing ([d153156](d153156)) * only sort if persisted unless it is display name ([#472](#472)) [skip release] ([4e4b5b8](4e4b5b8)) * ou-tree field styling ([f0e6d18](f0e6d18)) * prevent sidebar focus styles on mouse click ([c43aa2a](c43aa2a)) * reduce page-title bottom margin ([e4b3f0c](e4b3f0c)) * reduce sidebar filter padding ([f96633b](f96633b)) * remove global lineheight declaration ([6e92f6c](6e92f6c)) * sidebar filter placeholder label ([3259147](3259147)) * sidebar filter placeholder style ([70664f3](70664f3)) * sidebar, sidenav style adjustments ([501b53c](501b53c)) * sort columns using non case sensitive sort ([#469](#469)) [skip release] ([e05fd78](e05fd78)) * use destructive style for delete menu items ([209542b](209542b)) ### Features * do not allow creation of org units at level 1 unless it's the first ([#470](#470)) [skip release] ([21e73b8](21e73b8))
|
🎉 This PR is included in version 0.19.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.