feat: add hibernate.show_sql to dhis.conf

[vietnguyen]

No description provided.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[teleivo]

How is this different from changing the log4j2 config to enable logging 🤔

[teleivo]

dhis2-core/dhis-2/dhis-test-integration/src/test/resources/log4j2-test.xml

Lines 60 to 79 in c27640e

	<!-- JDBC template queries (SQL) -->
	<!--
	<Logger name="org.springframework.jdbc.core" level="debug" additivity="false">
	<AppenderRef ref="console"/>
	</Logger>-->
	<!-- Hibernate queries (SQL) -->
	<!--<Logger name="org.hibernate.SQL" level="TRACE">
	<AppenderRef ref="console"/>
	</Logger>-->
	<!-- Hibernate binding parameters -->
	<!--<Logger name="org.hibernate.type.descriptor.sql.BasicBinder" level="TRACE">
	<AppenderRef ref="console"/>
	</Logger>-->
	<!-- Uncomment if you want to debug our JUnit extension -->
	<!--<Logger name="org.hisp.dhis.test.junit" level="debug">
	<AppenderRef ref="console"/>
	</Logger>-->

[vietnguyen]

@teleivo Sometimes changing the log4j config doesn't work for me. Have you ever experienced that ?

[teleivo]

Mhm, I mean our log setup is pretty complex 😅 You need to configure the correct file depending on what/how you execute code. Maybe share your use case and we'll figure it out together. I just wonder if adding another way is not more confusing/complex 🤔 also if you want to see jdbc logs you'll need to go to log4j2.

[vietnguyen]

My use case is just to know what queries hibernate are generating in test and also production code.

I think using the log4j config is more complicated, and I also have to remember revert the changed before merging.

Using dhis.conf is straight forward, and i just need to change my local file. Maybe it's easier for debugging deployed instance, you don't need to look for the log4j file in the built folder.

I don't think there is a confusion regarding adding two ways to enable hibernate debug. It just helps to make the debugging job easier.