[WAIT] fix: Issue with missing headers when using Doris analytics database #19791
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // Increment the offset for row context (when applicable) | ||
| if (params.isRowContext()) { | ||
| addValueOriginInfo(grid, rowSet, header.getName()); | ||
| columnOffset += getRowSetOriginItems(rowSet, header.getName()); |
Check failure
Code scanning / CodeQL
Implicit narrowing conversion in compound assignment High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI 15 days ago
To fix the problem, we need to ensure that the type of columnOffset is at least as wide as the type returned by getRowSetOriginItems. The best way to fix this issue without changing existing functionality is to change the type of columnOffset from int to long. This will prevent any implicit narrowing conversion and ensure that the addition operation is safe.
| @@ -221,3 +221,3 @@ | ||
| // describing the repeating of repeatable stage. | ||
| int columnOffset = 0; | ||
| long columnOffset = 0; | ||
| // Start index for SqlRowSet columns. Starts at 1 (NOT 0, per ResultSet conventions). |
|
I am wondering if it would be better to handle this client side, and have the client inspect the headers and show/hide the long/lat fields based on the presence in the headers. |
larshelge
changed the title
|
Summary
This PR resolves an issue with non-aggregated analytics SQL queries in Doris/Clickhouse, specifically concerning their inability to process Postgis-related columns like latitude and longitude.
Changes
GridHeaderserves as a placeholder without corresponding to any column in the SQL result set.GridHeadersby providing default (empty) values in the grid when no underlying data is available.