chore: remove i18next and react-dom as direct dependencies #3138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jenniferarnesen
commented
Oct 29, 2024
•
jenniferarnesen
commented
- i18next gets installed as a dependency of d2-i18n, so it doesn't need to be a direct dependency in the app
- react-dom gets installed as a dependency of app-shell. And it was only used directly for testing. In the tests it has been replaced by a testing library. One useless test was removed.
|
🚀 Deployed on https://pr-3138.dashboard.netlify.dhis2.org |
edoardo
approved these changes
Oct 29, 2024
jenniferarnesen
changed the title
jenniferarnesen
added a commit
that referenced
this pull request
Oct 29, 2024
* i18next gets installed as a dependency of d2-i18n, so it doesn't need to be a direct dependency in the app * react-dom gets installed as a dependency of app-shell. And it was only used directly for testing. In the tests it has been replaced by a testing library. One useless test was removed.
jenniferarnesen
added a commit
that referenced
this pull request
Oct 29, 2024
* chore(deps): bump the security group with 4 updates Updates `express` from 4.19.2 to 4.21.1 - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/4.21.1/History.md) - [Commits](expressjs/express@4.19.2...4.21.1) Updates `path-to-regexp` from 0.1.7 to 0.1.10 - [Release notes](https://github.com/pillarjs/path-to-regexp/releases) - [Changelog](https://github.com/pillarjs/path-to-regexp/blob/master/History.md) - [Commits](pillarjs/path-to-regexp@v0.1.7...v0.1.10) Updates `send` from 0.18.0 to 0.19.0 - [Release notes](https://github.com/pillarjs/send/releases) - [Changelog](https://github.com/pillarjs/send/blob/master/HISTORY.md) - [Commits](pillarjs/send@0.18.0...0.19.0) Updates `serve-static` from 1.15.0 to 1.16.2 - [Release notes](https://github.com/expressjs/serve-static/releases) - [Changelog](https://github.com/expressjs/serve-static/blob/v1.16.2/HISTORY.md) - [Commits](expressjs/serve-static@v1.15.0...v1.16.2) --- updated-dependencies: - dependency-name: express dependency-type: indirect dependency-group: security - dependency-name: path-to-regexp dependency-type: indirect dependency-group: security - dependency-name: send dependency-type: indirect dependency-group: security - dependency-name: serve-static dependency-type: indirect dependency-group: security ... Signed-off-by: dependabot[bot] <support@github.com> * chore: remove i18next and react-dom as direct dependencies (#3138) * i18next gets installed as a dependency of d2-i18n, so it doesn't need to be a direct dependency in the app * react-dom gets installed as a dependency of app-shell. And it was only used directly for testing. In the tests it has been replaced by a testing library. One useless test was removed. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jen Jones Arnesen <jennifer@dhis2.org>
|
🎉 This PR is included in version 100.3.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.