Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fetch repetition data for LL to show in plugin v2.40.0 #2282

Merged

Conversation

edoardo
Copy link
Member

@edoardo edoardo commented Apr 4, 2023

Backport of #2271 .
(cherry picked from commit 25378ce)

Key features

  1. fetch repetition data for LL

Description

If a repeatable event was saved in a LL AO, it didn't show up in the plugin on dashboard.
The reason was because dashboard didn't fetch the repetition data with the rest of the fields passed to the plugin.


Screenshots

Before:
Screenshot 2023-03-22 at 14 56 54

After:
Screenshot 2023-03-23 at 10 59 11

* fix: fetch repetition data for LL to show in plugin

* chore: add PR template

(cherry picked from commit 25378ce)
@dhis2-bot
Copy link
Contributor

🚀 Deployed on https://pr-2282--dhis2-dashboard.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify April 4, 2023 13:15 Inactive
@cypress
Copy link

cypress bot commented Apr 4, 2023

Passing run #3235 ↗︎

0 51 0 0 Flakiness 0

Details:

chore: deduplicate yarn.lock
Project: dashboards-app Commit: 77a7ccd315
Status: Passed Duration: 05:23 💡
Started: Apr 4, 2023 1:14 PM Ended: Apr 4, 2023 1:20 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@janhenrikoverland janhenrikoverland merged commit 160882e into patch/2.40.0 Apr 5, 2023
@janhenrikoverland janhenrikoverland deleted the fix/repetitions-in-ll-plugins-v2.40.0 branch April 5, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants