fix: show offline message for EE maps [v40] [DHIS2-14993] #2268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: consolidate legacy and default plugin and fix ER/EV resizing * fix: show offline message on EE maps --------- Co-authored-by: Jan Henrik Øverland <janhenrik.overland@gmail.com>
jenniferarnesen
changed the title
|
🚀 Deployed on https://pr-2268--dhis2-dashboard.netlify.app |
edoardo
approved these changes
Mar 22, 2023
jenniferarnesen
added a commit
that referenced
this pull request
May 3, 2023
jenniferarnesen
added a commit
that referenced
this pull request
May 3, 2023
* fix: consolidate legacy and default plugin and fix resizing (#2254) (#2268) * fix: consolidate legacy and default plugin and fix ER/EV resizing * fix: show offline message on EE maps --------- Co-authored-by: Jan Henrik Øverland <janhenrik.overland@gmail.com> * fix: fix props handling when switching Map <-> DV plugins (#2272) * feat(iframe-plugin): wait to load plugins from cache to save network [DHIS2-15097] (#2285) * feat(iframe-plugin): receive pwa installation status from plugins * chore: add todos * fix: wait to render until the first item of the type has gotten the plugin * fix: add property to the top-most item of each iframe plugin type * fix: dont use the <Layer> component * chore: cli-app-scripts upgrade * fix: remove unused var * refactor: combine loops --------- Co-authored-by: Jen Jones Arnesen <jennifer@dhis2.org> * fix: disable ll plugin if it doesnt support installationStatus * fix: clean up and lint * fix: handle case where LL is not installed * fix: center spinner --------- Co-authored-by: Jan Henrik Øverland <janhenrik.overland@gmail.com> Co-authored-by: Edoardo Sabadelli <edoardo@dhis2.org> Co-authored-by: Kai Vandivier <49666798+KaiVandivier@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes 2 things:
Backport of #2254