fix: make landing page scrollable #2053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-2053--dhis2-dashboard.netlify.app |
martinkrulltott
approved these changes
Nov 4, 2021
dhis2-bot
added a commit
that referenced
this pull request
Nov 4, 2021
## [31.20.3](v31.20.2...v31.20.3) (2021-11-04) ### Bug Fixes * make landing page scrollable ([#2053](#2053)) ([2066f2b](2066f2b))
|
🎉 This PR is included in version 31.20.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the landing page scrollable. To enable a scrollbar the container needs a height, which in turn needs to be dynamic, so the height of the container is set by using flex-grow = 1 to make it fill the rest of the viewport height. To be able to use flex-grow the container's container needs to be flex. The new overflow rule is set on the StartScreen component so that it does not touch other stuff like dashboard print view.
Web:
https://user-images.githubusercontent.com/1010094/140347833-56e46d7d-51ce-41b3-9327-55df48611926.mp4
Mobile:
https://user-images.githubusercontent.com/1010094/140348329-a44247cf-c2c7-4273-b23b-f699549dc769.mp4