fix: close the More options menu when an option has been selected #2004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…7] (#1983) Fixes: https://jira.dhis2.org/browse/DHIS2-11773 The More options button and menu is complicated because there are 2 copies (of both the button and the menu) - one for small screen and one for not-small screen. So in order to toggle that menu, the small/not-small flag was being provided to the toggle function, but that flag was only available if clicking on the More button. When selecting an option in the menu, the menu should always be closed, so the solution was to trigger close on both menus. This code should probably be refactored for a cleaner solution than having 2 copies of the menu.
|
🚀 Deployed on https://pr-2004--dhis2-dashboard.netlify.app |
martinkrulltott
approved these changes
Sep 29, 2021
dhis2-bot
added a commit
that referenced
this pull request
Oct 1, 2021
## [31.19.14](v31.19.13...v31.19.14) (2021-10-01) ### Bug Fixes * **deps:** bump platform deps to clear sensitive caches and more ([#1999](#1999)) ([45a4ca2](45a4ca2)) * close the More options menu when an option has been selected [v37] ([#1983](#1983)) ([#2004](#2004)) ([6593bd4](6593bd4)) * **translations:** sync translations from transifex (master) ([#2000](#2000)) ([b893bd7](b893bd7))
|
🎉 This PR is included in version 31.19.14 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://jira.dhis2.org/browse/DHIS2-11773
Backport (forwardPort?) of #1983
The More options button and menu is complicated because there are 2 copies (of both the button and the menu) - one for small screen and one for not-small screen. So in order to toggle that menu, the small/not-small flag was being provided to the toggle function, but that flag was only available if clicking on the More button. When selecting an option in the menu, the menu should always be closed, so the solution was to trigger close on both menus.
This code should probably be refactored for a cleaner solution than having 2 copies of the menu.