Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disable View as Chart/Table for non-thematic maps (#1997) #1998

Merged
merged 1 commit into from
Sep 28, 2021
Merged

fix: disable View as Chart/Table for non-thematic maps (#1997) #1998

merged 1 commit into from
Sep 28, 2021

Commits on Sep 28, 2021

  1. fix: disable View as Chart/Table for non-thematic maps (#1997) 

    Fixes https://jira.dhis2.org/browse/DHIS2-11889

Fixes in this PR

* Open in [appName] app should be enabled even when offline
* When online, View as options for non-thematic maps should be disabled with tooltip "This map not available as a Chart"
* Dimension filter settings confirm button should not have an offline tooltip, because clicking the "Confirm" button doesn't trigger an api request
* Print button in More menu should be enabled for cached dashboards when offline
    @jenniferarnesen
    jenniferarnesen committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    b98bc56 View commit details
    Browse the repository at this point in the history