fix: disable dirty check on exit (DHIS2-11701) #1930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-1930--dhis2-dashboard.netlify.app |
jenniferarnesen
approved these changes
Sep 2, 2021
jenniferarnesen
pushed a commit
that referenced
this pull request
Sep 3, 2021
Removing the "dirty" check which would display the "Discard changes?" modal when "Exit without saving" was clicked after making changes to the title/description.
dhis2-bot
added a commit
that referenced
this pull request
Sep 3, 2021
## [31.19.1](v31.19.0...v31.19.1) (2021-09-03) ### Bug Fixes * bump cli-app-scripts to solve issues with z-index and Modals ([#1931](#1931)) ([d49347d](d49347d)) * disable dirty check on exit (DHIS2-11701) ([#1930](#1930)) ([f452540](f452540)) * readd missing offlinejs file ([#1929](#1929)) ([86851b1](86851b1)) * reduce cypress runners from 10 to 3 for fewer db conflicts ([#1937](#1937)) ([9c6a2e3](9c6a2e3)) * reenable cypress tests for offline ([#1928](#1928)) ([cbb782c](cbb782c)) * upgrade d2-ui 7.3.3 ([#1932](#1932)) ([09d446d](09d446d))
|
🎉 This PR is included in version 31.19.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
jenniferarnesen
added a commit
that referenced
this pull request
Sep 6, 2021
* fix: bump analytics and ui to latest (#1927) * feat: use the new SharingDialog with cascading sharing (#1913) * fix: reenable cypress tests for offline (#1928) * fix: readd missing offlinejs file (#1929) * fix: disable dirty check on exit (DHIS2-11701) (#1930) Removing the "dirty" check which would display the "Discard changes?" modal when "Exit without saving" was clicked after making changes to the title/description. * fix: bump cli-app-scripts to solve issues with z-index and Modals (#1931) Solves issues with ui Modals and z-index. Various Modals opened under the edit mode toolbar. Co-authored-by: Jen Jones Arnesen <jennifer@dhis2.org> * fix: upgrade d2-ui 7.3.3 (#1932) This upgrade fixes the broken interpretations component Co-authored-by: Martin <martin@moid.se> Co-authored-by: Edoardo Sabadelli <edoardo@dhis2.org> Co-authored-by: Jan Henrik Øverland <jan@dhis2.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the "dirty" check which would display the "Discard changes?" modal when "Exit without saving" was clicked after making changes to the title/description.