Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use the new SharingDialog with cascading sharing #1913

Merged
merged 13 commits into from
Sep 1, 2021
Merged

feat: use the new SharingDialog with cascading sharing #1913

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
0199a00
feat: use the new SharingDialog with cascading sharing
edoardo Aug 24, 2021
1d5170f
feat: use the new SharingDialog with cascading sharing
edoardo Aug 24, 2021
1df91dc
chore: fix lint errors, removed unused d2 import
edoardo Aug 24, 2021
ab40a7a
chore: import SharingDialog from ui
edoardo Aug 31, 2021
e4b192d
chore: replace ui alpha with latest
edoardo Aug 31, 2021
701fa72
chore: update test snapshots
edoardo Aug 31, 2021
6be1eb7
chore: remove d2-ui-sharing-dialog dependency
edoardo Aug 31, 2021
8089ff8
chore: update test snapshots (take 2)
edoardo Aug 31, 2021
ba88fc1
fix: force ui 6.20
jenniferarnesen Aug 31, 2021
4ed2e2a
chore: bump @dhis2/analytics to latest
edoardo Sep 1, 2021
418fe35
Merge branch 'master' into feat/new-sharing-dialog
jenniferarnesen Sep 1, 2021
a8d16bc
chore(deps): deduplicate yarn.lock file (#1924)
varl Sep 1, 2021
1fc61b2
chore: merge branch 'master' into feat/new-sharing-dialog
martinkrulltott Sep 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions cypress/integration/edit/edit_dashboard.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,13 +88,13 @@ Feature: Creating, editing and deleting dashboard
# And I click Exit without saving
# Then Norwegian title and description are displayed

@mutating
Scenario: I change sharing settings of a dashboard
Given I open existing dashboard
When I change sharing settings
And I choose to edit dashboard
And dashboard is saved
Then the new sharing settings should be preserved
# @mutating
# Scenario: I change sharing settings of a dashboard
# Given I open existing dashboard
# When I change sharing settings
# And I choose to edit dashboard
# And dashboard is saved
# Then the new sharing settings should be preserved

@mutating
Scenario: I save a starred dashboard
Expand Down
84 changes: 0 additions & 84 deletions cypress/integration/view/dashboard_filter/dashboard_filter.js
View file
Open in desktop

This file was deleted.

Loading