fix: add onError callback to handle failed chart from DV plugin [DHIS2-11303] [v36] #1832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edoardo
approved these changes
Jun 23, 2021
jenniferarnesen
added a commit
that referenced
this pull request
Jul 8, 2021
… [v36] (#1869) Backport of #1868 Remove the nested div that was causing the height for a visualization to not be set during edit mode. Fix was to restore the previous DOM structure, and just add a div around the error message with the needed height. This bug was introduced by the fix for DHIS2-11303. PR that introduced the bug: #1832 The other change in this PR is to improve the styling of the error message.
jenniferarnesen
added a commit
that referenced
this pull request
Jul 8, 2021
… [v36] (#1869) Backport of #1868 Remove the nested div that was causing the height for a visualization to not be set during edit mode. Fix was to restore the previous DOM structure, and just add a div around the error message with the needed height. This bug was introduced by the fix for DHIS2-11303. PR that introduced the bug: #1832 The other change in this PR is to improve the styling of the error message.
jenniferarnesen
added a commit
that referenced
this pull request
Jul 8, 2021
… [v36] (#1869) (#1870) Backport of #1868 Remove the nested div that was causing the height for a visualization to not be set during edit mode. Fix was to restore the previous DOM structure, and just add a div around the error message with the needed height. This bug was introduced by the fix for DHIS2-11303. PR that introduced the bug: #1832 The other change in this PR is to improve the styling of the error message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #1826
Add callback for errors from DataVisualizerPlugin. The implementation is based on the sketch from DHIS2-2839.
Changes to VisualizationItem/Item look like a lot, but the only change was to nest another
The key part of the fix is in DataVisualizerPlugin with the error handler, and resetting the error state when either the filter or the visualization type changes (i.e., View As Table).