fix: dashboard crashes if an item is missing type [TECH-588] #1812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edoardo
approved these changes
Jun 10, 2021
| <ItemHeader | ||
| itemId={item.id} | ||
| dashboardMode={dashboardMode} | ||
| isShortened={false} |
There was a problem hiding this comment.
Is item.shortened not available anymore? Or is it supposed to be always false for non supported items?
There was a problem hiding this comment.
Wait you are right. It could be shortened.
|
🎉 This PR is included in version 31.16.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One character fix in
itemTypes.jsThe rest is support for new cypress tests that mock a request with missing or unrecognized item types.
Look at
view_errors.featurefor a summary of what the new new cypress tests do. Some cypress changes are just moving functions tocommonso that all tests can access the function