fix: all cypress tests in edit mode should check that view mode is displayed first #1769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenniferarnesen
changed the title
martinkrulltott
approved these changes
May 18, 2021
| cy.location().should(loc => { | ||
| const currentRoute = getRouteFromHash(loc.hash) | ||
|
|
||
| expect(nonViewRoutes).not.to.include(currentRoute) |
There was a problem hiding this comment.
This works, but my spontaneous thought was to check that it's a valid uid (i.e. valid format, not valid in the db).
There was a problem hiding this comment.
Actually, maybe that's what you're doing on the line below though? 🤔
dhis2-bot
added a commit
that referenced
this pull request
May 18, 2021
## [31.15.4](v31.15.3...v31.15.4) (2021-05-18) ### Bug Fixes * all cypress tests in edit mode should check that view mode is displayed first ([#1769](#1769)) ([0be9fb1](0be9fb1))
|
🎉 This PR is included in version 31.15.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests occasionally fail because a button (e.g. Share) is not yet visible. This change adds a check for each test that ensures that view mode has been rendered before moving on with the rest of the test.