fix: expanded control bar not resizing on drag [DHIS2-10795] #1681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenniferarnesen
changed the title
martinkrulltott
approved these changes
Mar 30, 2021
dhis2-bot
added a commit
that referenced
this pull request
Mar 30, 2021
## [31.14.10](v31.14.9...v31.14.10) (2021-03-30) ### Bug Fixes * expanded control bar not resizing on drag [DHIS2-10795] ([#1681](#1681)) ([e857c03](e857c03))
|
🎉 This PR is included in version 31.14.10 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
jenniferarnesen
added a commit
that referenced
this pull request
Jul 2, 2021
…1858) Bug fix: remove the expanded flag if dragging has decreased the controlbar height to less than max height. Backport of #1681 For the smoother resize experience: * reduced re-rendering of DragHandle by using React.memo (this also results in a smoother drag experience since the initial startingY state doesn't get reset to 0) * use Math.round instead of Math.floor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix: remove the expanded flag if dragging has decreased the controlbar height to less than max height.
For the smoother resize experience:
Before:
After:
Before (jumpy resize - notice how when you first downpress on the drag handle, the controlbar resizes to one less row before being resized to taller (more rows):
After: (smoother resize):