fix: print page width #1657
Merged
fix: print page width #1657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinkrulltott
approved these changes
Mar 19, 2021
dhis2-bot
added a commit
that referenced
this pull request
Mar 22, 2021
## [31.14.6](v31.14.5...v31.14.6) (2021-03-22) ### Bug Fixes * avoid double rendering of chart visualizations ([#1658](#1658)) ([613ae75](613ae75)) * maps, ev and er were not resizing for fullscreen or item resize in edit mode ([#1659](#1659)) ([c56b562](c56b562)) * maximum grid width was hanging past right edge of paper in print preview ([#1657](#1657)) ([7faf5c2](7faf5c2))
|
🎉 This PR is included in version 31.14.6 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
jenniferarnesen
added a commit
that referenced
this pull request
Mar 23, 2021
… preview (#1657) Switching to a responsive grid has changed the geometries of the items just slightly, so that in print preview - full width items would hang over the right edge of the paper (the actual print still looked ok). Solution was to reduce the width of the print grid (StaticGrid). Other changes are refactoring - using a single variable to hold the A4 landscape page width.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow, switching to a responsive grid has changed the geometries of the items just slightly, so that in print preview - full width items would hang over the right edge of the paper (the actual print still looked ok). Solution was to reduce the width of the print grid (StaticGrid). Other changes are refactoring - using a single variable to hold the A4 landscape page width.
Before:
After:
