fix: upgrade to @dhis2/cli-app-scripts@6 (DHIS2-9893) #1634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pretty slick for what is basically a two file update! |
varl
approved these changes
Mar 11, 2021
dhis2-bot
added a commit
that referenced
this pull request
Mar 12, 2021
## [31.14.3](v31.14.2...v31.14.3) (2021-03-12) ### Bug Fixes * @dhis2/analytics@16.0.15, @dhis2/data-visualizer-plugin@35.20.18 ([#1645](#1645)) ([bfa9889](bfa9889)) * **translations:** sync translations from transifex (master) ([#1585](#1585)) ([45b3524](45b3524)) * upgrade to @dhis2/cli-app-scripts@6 (DHIS2-9893) ([#1634](#1634)) ([662fd6e](662fd6e))
|
🎉 This PR is included in version 31.14.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of DHIS2-9893
Upgrades ui, cli-app-scripts, app-runtime, d2-i18n, and analytics
Tree shaking combined with lazy plugin loading gives us a savings of 1.5MB (!!!!) javascript payload (gzipped) when no EV or ER plugins are present. Those add another ~1MB though.
Maps plugin slimming will increase the benefit here as well.
Before
After
The initial render-blocking load (before plugin code is fetched) is reduced from 3.1MB gzipped 🥴 to just 547kb 🎉 -- still too much and we should look into non-js bloat but MUCH improved!
Before
After
