fix: progressive loading on small screen fixes #1610
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed:
transform
property). To fix this, a MutationObserver was added to observe changes to the style of the grid item (assumption is that it is thetransform
property that is updated. Other possible style changes arewidth
andheight
. Either of those changing would also suggest that the item had moved). This also fixes a pre-existing bug in Edit mode where, if you delete items and unloaded items from below on the dashboard move up into the viewport, they didn't get loaded. Note that the observer is only observing for unloaded items.Before: Small screen - portrait->landscape - notice that all items are already loaded
sm.sc.loading.before.mov
After: small screen portrait->landscape - progressive loading works
sm.sc.loading.after.mov
Before: edit mode - unloaded items don't load when moved into viewport (as items above it are deleted)
prog.loading.edit.mode.before.mov
After: edit mode - unloaded items load when moved into viewport
prog.loading.edit.mode.after.mov