Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: phone landscape scrolling in edit mode was not available #1594

Merged
merged 9 commits into from
Mar 3, 2021
Merged

fix: phone landscape scrolling in edit mode was not available #1594

merged 9 commits into from
Mar 3, 2021

Conversation

jenniferarnesen
Copy link
Collaborator

@jenniferarnesen jenniferarnesen commented Mar 2, 2021 •
edited
Loading

Code changes to fix:

  • Edit controlbar now scrolls away same as View control bar (added overflow-y: auto)
  • add dashboard-scroll-container class bc progressive loading listens to the scrolling to determine when to load an item.
  • remove bottom padding on the NoContentMessage since it sometimes caused the content of the scroll container to exceed the container height, forcing a scrollbar even though there was no real scroll content.

Broken:

landscape.edit.scroll.issues.mov

Fixed:

edit.mode.scroll.away.ctrlbar.mov

@jenniferarnesen jenniferarnesen marked this pull request as draft March 2, 2021 12:13
@jenniferarnesen jenniferarnesen marked this pull request as ready for review March 2, 2021 13:02
@jenniferarnesen jenniferarnesen merged commit 6bfc650 into master Mar 3, 2021
@jenniferarnesen jenniferarnesen deleted the fix/phone-landscape-edit-scrolling branch March 3, 2021 09:28
dhis2-bot added a commit that referenced this pull request Mar 4, 2021
@dhis2-bot
chore(release): cut 31.13.3 [skip ci]
827f643 
## [31.13.3](v31.13.2...v31.13.3) (2021-03-04)

### Bug Fixes

* do not allow "Open in [appname] app" when in small screen ([#1593](#1593)) ([56ad5b5](56ad5b5))
* phone landscape scrolling in edit mode was not available ([#1594](#1594)) ([6bfc650](6bfc650))
* temporarily disable flaky cypress test ([#1599](#1599)) ([b338564](b338564))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 31.13.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinkrulltott martinkrulltott martinkrulltott approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jenniferarnesen @dhis2-bot @martinkrulltott