Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: spacing between titlebar and filter badge #1551

Merged
merged 1 commit into from
Feb 18, 2021

Conversation

jenniferarnesen
Copy link
Collaborator

@jenniferarnesen jenniferarnesen commented Feb 18, 2021

The recent changes for responsive dashboard caused too much space between the titlebar and the filter badges

Minor refactoring:

  • FilterBadge and FilterBar changed to functional components
  • style moved to css module
  • FilterBar simplified to basically just be a container for managing the position of the badges
  • redux connected the FilterBadges resulting in simpler event callbacks

Before:
image

After (returned to as before, with a small adjust to # pixels to comply with the design system spacing):
image

@jenniferarnesen jenniferarnesen merged commit 45d90d5 into master Feb 18, 2021
@jenniferarnesen jenniferarnesen deleted the fix/filter-badge-position branch February 18, 2021 13:14
dhis2-bot added a commit that referenced this pull request Feb 18, 2021
## [31.12.1](v31.12.0...v31.12.1) (2021-02-18)

### Bug Fixes

* spacing between titlebar and filter badge ([#1551](#1551)) ([45d90d5](45d90d5))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 31.12.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants