feat: scroll away control bar when viewing dashboard on screen with height <=480px #1550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenniferarnesen
changed the title
edoardo
approved these changes
Feb 18, 2021
| document.getElementsByClassName('dashboard-scroll-container') | ||
| ).forEach(container => { | ||
| container.scroll(0, 0) | ||
| }) |
There was a problem hiding this comment.
Why not using querySelector still?
I understand there is always only 1 element with that class.
Or maybe use this instead?
Suggested change
| }) | |
| document.getElementsByClassName('dashboard-scroll-container').item(0)?.scroll(0,0) |
There was a problem hiding this comment.
Actually, there can be 2 elements with the class
There was a problem hiding this comment.
Yes, i missed the one in DashboardContainer.
Nvm the comments.
| Array.from( | ||
| document.getElementsByClassName('dashboard-scroll-container') | ||
| ).forEach(container => { | ||
| container.addEventListener( |
dhis2-bot
added a commit
that referenced
this pull request
Feb 18, 2021
# [31.12.0](v31.11.2...v31.12.0) (2021-02-18) ### Features * scroll away control bar when viewing dashboard on screen with height <=480px ([#1550](#1550)) ([0caf0d8](0caf0d8))
|
🎉 This PR is included in version 31.12.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the screen height is <=480px, then scroll all the content, including the control bar. When more than 480px, scroll only the actual dashboard. Note that progressive loading is not working consistently right now (pre-existing issue - currently being investigated)
Small refactor:
scrollctrlbar.mov