fix: provide better message when edit mode becomes unavailable [DHIS2-10138] #1514
Conversation
jenniferarnesen
commented
Feb 5, 2021
•
jenniferarnesen
commented
There was a problem hiding this comment.
Resize your screen to return to edit... is this really intuitive for mobile viewing?
How do I "resize" my phone?
My thinking behind this message is that this is as generic as we can be without ruling out other devices. "Resize your screen..." is not a perfect analogy for mobile, but it serves the purpose of covering all other devices like tablets in split screen, small desktop windows etc. It is not restrictive.
Mentioning "landscape" or "turn your phone" suits the mobile device use case better, but in my opinion it is restrictive for other edge cases. Mentioning anything to do with a phone/mobile device will imply that the application cannot/should not be used on other devices, which isn't the case.
This reverts commit 759ec80.
## [31.10.4](v31.10.3...v31.10.4) (2021-02-08) ### Bug Fixes * provide more informative message when edit mode becomes unavailable [DHIS2-10138] ([#1514](#1514)) ([4e080bb](4e080bb))
|
🎉 This PR is included in version 31.10.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
