Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check whether the dashboard id has been set after the check for existing dashboards [DHIS2-9738] [patch/2.35.0] #1167

Merged
merged 2 commits into from
Oct 12, 2020
Merged

fix: check whether the dashboard id has been set after the check for existing dashboards [DHIS2-9738] [patch/2.35.0] #1167

merged 2 commits into from
Oct 12, 2020

Commits on Oct 12, 2020

  1. fix: check whether the dashboard id has been set after the check for … 

    …existing dashboards [DHIS2-9738] (#1164)

The state checks need to happen in a certain order, unfortunately. In an empty database, the id never gets set, resulting in an infinite circular loader. So that check needs to happen after the check for existing dashboards. In an empty database, there are no dashboards.
    @jenniferarnesen
    jenniferarnesen committed Oct 12, 2020
    Configuration menu
    Copy the full SHA
    82a2d37 View commit details
    Browse the repository at this point in the history

  2. fix: adjust test to replicate empty dashboards state

    @jenniferarnesen
    jenniferarnesen committed Oct 12, 2020
    Configuration menu
    Copy the full SHA
    4fc3a58 View commit details
    Browse the repository at this point in the history