fix: fix props handling when switching Map <-> DV plugins #2272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-2272--dhis2-dashboard.netlify.app |
Passing run #3223 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
jenniferarnesen
approved these changes
Mar 24, 2023
|
🎉 This PR is included in version 99.10.23 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
jenniferarnesen
pushed a commit
that referenced
this pull request
May 3, 2023
jenniferarnesen
pushed a commit
that referenced
this pull request
May 3, 2023
jenniferarnesen
added a commit
that referenced
this pull request
May 3, 2023
* fix: consolidate legacy and default plugin and fix resizing (#2254) (#2268) * fix: consolidate legacy and default plugin and fix ER/EV resizing * fix: show offline message on EE maps --------- Co-authored-by: Jan Henrik Øverland <janhenrik.overland@gmail.com> * fix: fix props handling when switching Map <-> DV plugins (#2272) * feat(iframe-plugin): wait to load plugins from cache to save network [DHIS2-15097] (#2285) * feat(iframe-plugin): receive pwa installation status from plugins * chore: add todos * fix: wait to render until the first item of the type has gotten the plugin * fix: add property to the top-most item of each iframe plugin type * fix: dont use the <Layer> component * chore: cli-app-scripts upgrade * fix: remove unused var * refactor: combine loops --------- Co-authored-by: Jen Jones Arnesen <jennifer@dhis2.org> * fix: disable ll plugin if it doesnt support installationStatus * fix: clean up and lint * fix: handle case where LL is not installed * fix: center spinner --------- Co-authored-by: Jan Henrik Øverland <janhenrik.overland@gmail.com> Co-authored-by: Edoardo Sabadelli <edoardo@dhis2.org> Co-authored-by: Kai Vandivier <49666798+KaiVandivier@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key features
Description
When using "View as" and switching between Map and chart/table or viceversa, the plugin loaded in the iframe needs to change.
This transition didn't work because the message listener in dashboard was not in place when the plugin requested
getProps, resulting in the Map/chart/table not showing.Switching between chart and table worked because in that case the plugin does not change and the
newPropsmessage is used instead ofgetProps.The
getPropslistener is still removed in the cleanup function returned by the useEffect, but it's recreated if the iframe src change (plugin change).After the first
getPropsmessage is received there shouldn't be othergetPropsmessages incoming, butnewPropsis used for passing new/modified props instead.Screenshots
Before:
https://user-images.githubusercontent.com/150978/227541666-4c0ec880-0eed-4b8f-bce0-3656bddb5284.mov
After:
https://user-images.githubusercontent.com/150978/227542408-996b818a-c1ba-473e-b007-5d2f60c762f5.mov