Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fetch repetition data for LL to show in plugin #2271

Merged
merged 2 commits into from
Mar 23, 2023

Conversation

edoardo
Copy link
Member

@edoardo edoardo commented Mar 23, 2023

Key features

  1. fetch repetition data for LL

Description

If a repeatable event was saved in a LL AO, it didn't show up in the plugin on dashboard.
The reason was because dashboard didn't fetch the repetition data with the rest of the fields passed to the plugin.


Screenshots

Before:
Screenshot 2023-03-22 at 14 56 54

After:
Screenshot 2023-03-23 at 10 59 11

@dhis2-bot
Copy link
Contributor

🚀 Deployed on https://pr-2271--dhis2-dashboard.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify March 23, 2023 10:02 Inactive
@cypress
Copy link

cypress bot commented Mar 23, 2023

Passing run #3217 ↗︎

0 51 0 0 Flakiness 0

Details:

chore: add PR template
Project: dashboards-app Commit: 5b479aa9d3
Status: Passed Duration: 04:37 💡
Started: Mar 23, 2023 9:58 AM Ended: Mar 23, 2023 10:03 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@janhenrikoverland janhenrikoverland merged commit 25378ce into master Mar 23, 2023
@janhenrikoverland janhenrikoverland deleted the fix/repetitions-in-ll-plugins branch March 23, 2023 14:25
dhis2-bot added a commit that referenced this pull request Mar 24, 2023
## [99.10.23](v99.10.22...v99.10.23) (2023-03-24)

### Bug Fixes

* fetch repetition data for LL to show in plugin ([#2271](#2271)) ([25378ce](25378ce))
* fix props handling when switching Map <-> DV plugins ([#2272](#2272)) ([7a06ab9](7a06ab9))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 99.10.23 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

edoardo added a commit that referenced this pull request Apr 4, 2023
* fix: fetch repetition data for LL to show in plugin

* chore: add PR template

(cherry picked from commit 25378ce)
janhenrikoverland pushed a commit that referenced this pull request Apr 5, 2023
* fix: fetch repetition data for LL to show in plugin

* chore: add PR template

(cherry picked from commit 25378ce)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants