fix: remove other action buttons when in print preview #1974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenniferarnesen
requested review from
janhenrikoverland and
martinkrulltott
|
🚀 Deployed on https://pr-1974--dhis2-dashboard.netlify.app |
martinkrulltott
approved these changes
Sep 14, 2021
dhis2-bot
added a commit
that referenced
this pull request
Sep 15, 2021
## [31.19.11](v31.19.10...v31.19.11) (2021-09-15) ### Bug Fixes * **translations:** sync translations from transifex (master) ([#1968](#1968)) ([66070be](66070be)) * analytics@20.4.7, data-visualizer-plugin@38.0.13 ([#1981](#1981)) ([30b25fb](30b25fb)) * in small screen make the "editing not possible" message the same whether in create or edit mode ([#1972](#1972)) ([1b9a193](1b9a193)) * remove other action buttons when in edit mode print preview ([#1974](#1974)) ([e9a54d1](e9a54d1)) * when loading a dashboard set the loaded flag after the fetch so state doesn't toggle back and forth ([#1975](#1975)) ([c9b4ff7](c9b4ff7))
|
🎉 This PR is included in version 31.19.11 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This was referenced Jan 10, 2022
jenniferarnesen
added a commit
that referenced
this pull request
Jan 17, 2022
Backport of #1974 To prevent the user from accidentally losing their changes while in print preview mode, remove all action buttons other than "Exit print preview". The files changed view looks like major changes were made, but the only change is the addition of the !props.isPrintPreviewView for all the buttons.
jenniferarnesen
added a commit
that referenced
this pull request
Jan 17, 2022
Backport of #1974 To prevent the user from accidentally losing their changes while in print preview mode, remove all action buttons other than "Exit print preview". The files changed view looks like lots of changes were made, but the only change is the addition of the !props.isPrintPreviewView for all the buttons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent the user from accidentally losing their changes while in print preview mode, remove all action buttons other than "Exit print preview". We realized there could be some confusion between "Exit print preview" and "Exit without saving".
The
Exit print previewbutton jumps left from thePrint previewbutton, which is maybe not ideal.The files changed view looks like major changes were made, but the only change is the addition of the
!props.isPrintPreviewViewfor all the buttons. Note that there are other checks for displaying those buttons as well, like access level for the Delete and Save buttons, so there is some added complexity and additional factors coming into play there.exit.print.preview.mov