Skip to content

Commit

Permalink
fix: in small screen make the "editing not possible" message the same…
Browse files Browse the repository at this point in the history
… whether in create or edit mode (#1972)

When user goes to small screen while making a new dashboard, the message should be the same as when editing an existing dashboard.
  • Loading branch information
jenniferarnesen authored Sep 14, 2021
1 parent 8bd01ae commit 1b9a193
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 12 deletions.
11 changes: 2 additions & 9 deletions i18n/en.pot
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ msgstr ""
"Content-Type: text/plain; charset=utf-8\n"
"Content-Transfer-Encoding: 8bit\n"
"Plural-Forms: nplurals=2; plural=(n != 1)\n"
"POT-Creation-Date: 2021-09-09T12:38:10.210Z\n"
"PO-Revision-Date: 2021-09-09T12:38:10.210Z\n"
"POT-Creation-Date: 2021-09-14T10:06:01.370Z\n"
"PO-Revision-Date: 2021-09-14T10:06:01.370Z\n"

msgid "Untitled dashboard"
msgstr "Untitled dashboard"
Expand Down Expand Up @@ -314,13 +314,6 @@ msgstr "Default height for items added to dashboard (rows)"
msgid "Save layout"
msgstr "Save layout"

msgid ""
"Creating dashboards on small screens is not supported. Resize your screen "
"to return to create mode."
msgstr ""
"Creating dashboards on small screens is not supported. Resize your screen "
"to return to create mode."

msgid "Dashboard title"
msgstr "Dashboard title"

Expand Down
2 changes: 1 addition & 1 deletion src/pages/edit/NewDashboard.js
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ const NewDashboard = props => {
<Notice
title={i18n.t('Not supported')}
message={i18n.t(
'Creating dashboards on small screens is not supported. Resize your screen to return to create mode.'
'Editing dashboards on small screens is not supported. Resize your screen to return to edit mode.'
)}
/>
</div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ exports[`NewDashboard renders dashboard 1`] = `
class="jsx-3638294246"
data-test="dhis2-uicore-noticebox-message"
>
Creating dashboards on small screens is not supported. Resize your screen to return to create mode.
Editing dashboards on small screens is not supported. Resize your screen to return to edit mode.
</div>
</div>
</div>
Expand Down Expand Up @@ -143,7 +143,7 @@ exports[`NewDashboard renders print preview 1`] = `
class="jsx-3638294246"
data-test="dhis2-uicore-noticebox-message"
>
Creating dashboards on small screens is not supported. Resize your screen to return to create mode.
Editing dashboards on small screens is not supported. Resize your screen to return to edit mode.
</div>
</div>
</div>
Expand Down

0 comments on commit 1b9a193

Please sign in to comment.