fix: add onError callback to handle failed chart from DV plugin [DHIS2-11303] #1826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edoardo
approved these changes
Jun 21, 2021
…:dhis2/dashboard-app into fix/empty-chart-when-analytics-req-fails
dhis2-bot
added a commit
that referenced
this pull request
Jun 22, 2021
## [31.16.3](v31.16.2...v31.16.3) (2021-06-22) ### Bug Fixes * add onError callback to handle failed chart from DV plugin [DHIS2-11303] ([#1826](#1826)) ([2aa5f6b](2aa5f6b))
|
🎉 This PR is included in version 31.16.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This was referenced Jul 6, 2021
jenniferarnesen
added a commit
that referenced
this pull request
Jul 8, 2021
Fixes DHIS2-11303 Backport of #1826 Add callback for errors from DataVisualizerPlugin. The implementation is based on the sketch from DHIS2-2839.
jenniferarnesen
added a commit
that referenced
this pull request
Aug 11, 2021
…#1868) Remove the nested div that was causing the height for a visualization to not be set during edit mode. Fix was to restore the previous DOM structure, and just add a div around the error message with the needed height. This bug was introduced by the fix for DHIS2-11303. PR that introduced the bug: #1826
dhis2-bot
added a commit
that referenced
this pull request
Aug 12, 2021
## [31.17.1](v31.17.0...v31.17.1) (2021-08-12) ### Bug Fixes * bump dv plugin and ui to latest ([#1892](#1892)) ([89dd128](89dd128)) * set correct item height when adding dashboard items in edit mode ([#1868](#1868)) ([41575f4](41575f4)), closes [#1826](#1826) * the response code for PUT userDataStore has been changed from 201 to 200 ([#1896](#1896)) ([ced4258](ced4258))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add callback for errors from DataVisualizerPlugin. The implementation is based on the sketch from DHIS2-2839.
Changes to VisualizationItem/Item look like a lot, but the only change was to nest another
<div>so that the error message could be centered vertically.The key part of the fix is in DataVisualizerPlugin with the error handler, and resetting the error state when either the filter or the visualization type changes (i.e., View As Table).
In print mode - the link is not displayed:
chart-invalid-filter.mov