fix: correctly detect italic/bold marker after non-word char (DHIS2-9382) #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just to keep it consistent with the other regex and avoid possible problems with the code that uses the regex results.
edoardo
changed the title
This was referenced Sep 10, 2020
edoardo
added a commit
to dhis2/data-visualizer-app
that referenced
this pull request
Sep 25, 2020
Backport. The fix is in the d2-ui-interpretations component. See: dhis2/d2-ui#624.
edoardo
added a commit
to dhis2/data-visualizer-app
that referenced
this pull request
Sep 25, 2020
Backport. The fix is in the d2-ui-interpretations component. See: dhis2/d2-ui#624.
dhis2-bot
added a commit
to dhis2/data-visualizer-app
that referenced
this pull request
Sep 25, 2020
## [34.6.25](v34.6.24...v34.6.25) (2020-09-25) ### Bug Fixes * rich text parsing issue (DHIS2-9382) ([#1263](#1263)) ([f8b2f88](f8b2f88)), closes [dhis2/d2-ui#624](dhis2/d2-ui#624) * set a default name if saved vis is untitled ([#1314](#1314)) ([41c264e](41c264e)), closes [#1273](#1273)
dhis2-bot
added a commit
to dhis2/data-visualizer-app
that referenced
this pull request
Sep 25, 2020
## [33.1.20](v33.1.19...v33.1.20) (2020-09-25) ### Bug Fixes * rich text parsing issue (DHIS2-9382) v33 ([#1264](#1264)) ([91c76cf](91c76cf)), closes [dhis2/d2-ui#624](dhis2/d2-ui#624)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DHIS2-9382.
Changes proposed in this pull request:
Fixes the specific case reported in the ticket and any other string where a non-word character is the last character before the closing italic/bold marker.