fix(auto login): ensure something has rendered in validation fn #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
May 1, 2023
There was a problem hiding this comment.
I've been using this to login:
cy.session(
user,
() => {
// Login via API
cy.request({
url: `${user.server}/dhis-web-commons-security/login.action`,
method: 'POST',
form: true,
followRedirect: true,
body: {
j_username: user.name,
j_password: user.password,
'2fa_code': '',
},
})
// Set base url for the app platform
window.localStorage.setItem('DHIS2_BASE_URL', user.server)
},
{
validate: () => {
cy.request(`${user.server}/api/me`).then((response) => {
expect(response.status).to.eq(200)
expect(response.body.username).to.eq(user.name)
})
},
}
)It's been a little faster for me than using the ui. Plus you're not dependent on rendering or any other FE parts. Would that be a solution you could use here?
Co-authored-by: Ismay <Ismay@users.noreply.github.com>
|
I've implemented your suggestions but created commands for those particular tasks (logging in by api and validating a user session) |
ghost
reviewed
May 1, 2023
| @@ -0,0 +1,6 @@ | |||
| Cypress.Commands.add('validateUserIsLoggedIn', ({ baseUrl, username }) => { | |||
There was a problem hiding this comment.
You could also call this validateSession maybe. Seems a little terser to me.
ghost
approved these changes
May 1, 2023
dhis2-bot
added a commit
that referenced
this pull request
May 1, 2023
## [10.0.1](v10.0.0...v10.0.1) (2023-05-01) ### Bug Fixes * **auto login:** use api to login ([#394](#394)) ([8b22e7b](8b22e7b))
|
🎉 This PR is included in version 10.0.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the
.should('not.exist')check in the validate function was run before the app rendered anything, causing login issues.By adding the change of this PR to the code inside
node_modulesin the aggregate data entry app'supgrade_cypress_to_v12branch, it then ran capturing & stubbing successfully consistently.