Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [DHIS2-18632] Sorting stage detail table on orgunit breaks the app #3917

Merged

Conversation

henrikmv
Copy link
Contributor

@henrikmv henrikmv commented Dec 20, 2024

DHIS2-18632

  • Changed type from TEXT to ORGANISATION_UNIT
  • Org. unit is now converted withinclientToList
  • Reimplemented getCachedOrgUnitName function to handle sorting (removed in DHIS2-17771)

@henrikmv henrikmv marked this pull request as ready for review December 20, 2024 09:41
@henrikmv henrikmv requested a review from a team as a code owner December 20, 2024 09:41
Copy link

github-actions bot commented Dec 20, 2024

Copy link

@geethaalwan geethaalwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully on 2.42,2.41.3,2.40.7,2.39.9 versions

@henrikmv henrikmv added testing and removed testing labels Jan 7, 2025
@henrikmv henrikmv merged commit 15414cc into master Jan 8, 2025
40 checks passed
@henrikmv henrikmv deleted the hv/fix/DHIS2-18632_FilteringStageDetailTableIOnOrgunit branch January 8, 2025 09:57
dhis2-bot added a commit that referenced this pull request Jan 8, 2025
## [101.21.1](v101.21.0...v101.21.1) (2025-01-08)

### Bug Fixes

* [DHIS2-18632] Sorting stage detail table on orgunit breaks the app ([#3917](#3917)) ([15414cc](15414cc))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 101.21.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants