Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [DHIS2-17613] Use new note endpoint #3908

Merged
merged 9 commits into from
Jan 12, 2025

Conversation

henrikmv
Copy link
Contributor

@henrikmv henrikmv commented Dec 14, 2024

DHIS2-17613

For version 42:

  • POST /enrollments/${enrollmentId}/note ----> POST /tracker/enrollments/{enrollmentUid}/note
  • POST /events/${eventId}/note ----> POST /tracker/events/{eventUid}/note

Using the featureAvailable function to determine whether the new API is applicable to the current version.

@henrikmv henrikmv marked this pull request as ready for review December 14, 2024 18:32
@henrikmv henrikmv requested a review from a team as a code owner December 14, 2024 18:32
Copy link

github-actions bot commented Dec 14, 2024

Copy link
Contributor

@simonadomnisoru simonadomnisoru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@henrikmv,
Could use the new endpoints when adding notes for the single events too in viewEventNotes.actions.js?
Thanks!

@henrikmv
Copy link
Contributor Author

henrikmv commented Dec 23, 2024

@simonadomnisoru

I’ve now used the functionAvailable function to determine whether the new API applies to the current version.

Copy link

@geethaalwan geethaalwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully on 2.42 version

@henrikmv henrikmv added testing and removed testing labels Jan 10, 2025
@henrikmv henrikmv merged commit a9fdea8 into master Jan 12, 2025
40 checks passed
@henrikmv henrikmv deleted the hv/fix/DHIS2-17613_UseNewNoteEndpoints branch January 12, 2025 16:35
dhis2-bot added a commit that referenced this pull request Jan 12, 2025
## [101.21.3](v101.21.2...v101.21.3) (2025-01-12)

### Bug Fixes

* [DHIS2-17613] Use new note endpoint ([#3908](#3908)) ([a9fdea8](a9fdea8))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 101.21.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants