Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [DHIS2-15212][DHIS2-15214][DHIS2-15216] Referral widget actions #3458

Merged

Conversation

eirikhaugstulen
Copy link
Contributor

@eirikhaugstulen eirikhaugstulen commented Nov 4, 2023

This PR includes three issues:

This issue is blocked by two issues that seems like backend bugs:

  • /tracker/events does not seem to return relationships in the payload. This makes the Link to existing button active if there are events in the response stage, even if they have already been linked. Will follow up with BE.
  • In /tracker/events status does not accept a list, which means that completed events is also returned. Not a blocker as we can always do some filtering on the front end

Things left to develop:

  • The issue mentions that if the user clicks Save without completion, there should be a modal that informs the user that referral will be added. This is awaiting design.

@eirikhaugstulen eirikhaugstulen changed the base branch from master to DHIS2-13299-referrals November 4, 2023 15:46
@eirikhaugstulen eirikhaugstulen marked this pull request as ready for review November 4, 2023 16:34
@eirikhaugstulen eirikhaugstulen requested a review from a team as a code owner November 4, 2023 16:34
Copy link

github-actions bot commented Nov 4, 2023

@eirikhaugstulen eirikhaugstulen changed the title feat: [DHIS2-13299] Referral widget feat: [DHIS2-15212][DHIS2-15214][DHIS2-15216] Referral widget actions Nov 5, 2023
@eirikhaugstulen eirikhaugstulen merged commit 6cef430 into DHIS2-13299-referrals Dec 18, 2023
33 of 40 checks passed
@eirikhaugstulen eirikhaugstulen deleted the eh/feat/DHIS2-15216_DontLinkReferral branch December 18, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant