fix: separator for hundreds, thousands and millions is missing in the Pie charts (DHIS2-16172) #1677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edoardo
approved these changes
Jun 10, 2024
edoardo
approved these changes
Jun 12, 2024
dhis2-bot
added a commit
that referenced
this pull request
Jun 12, 2024
## [26.7.2](v26.7.1...v26.7.2) (2024-06-12) ### Bug Fixes * separator for hundreds, thousands and millions is missing in the Pie charts (DHIS2-16172) ([#1677](#1677)) ([ad8c799](ad8c799))
|
🎉 This PR is included in version 26.7.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
martinkrulltott
added a commit
that referenced
this pull request
Jun 12, 2024
… Pie charts (DHIS2-16172) (#1677)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements DHIS2-16172
Relates to dhis2/data-visualizer-app#3093
Key features
Description
The value now has a thousand separator, e.g.
1000->1 000. The decimals are intact for the value, e.g.1000,01->1 000,01The percentage now renders without a trailing zero, e.g.
100,0->100. This only affects zeros, so real decimal values will still be rendered (rounded to 1 decimal point), e.g.100,12->100,1TODO
1234.5678outputting as1 234.5 678Screenshots
before, no thousand separator for value, percentage has trailing zero
after, adds thousand separator for value, no percentage trailing zero