Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dimension list design (DHIS2-16270) #1530

Merged
merged 24 commits into from
May 14, 2024
Merged

Conversation

cooper-joe
Copy link
Member

@cooper-joe cooper-joe commented Jun 29, 2023

Implements DHIS2-16270, matching inbound design changes in Data Visualizer in #2934, which is required for this change to display correctly in DV.

Build analytics with yarn build --watch, then use in DV with rm -rf node_modules/@dhis2/analytics/build && cp -R ../analytics/build/ node_modules/@dhis2/analytics/build && yarn start

image

@janhenrikoverland
Copy link
Collaborator

Looks like this in DV

Screenshot from 2023-09-01 10-21-35
Screenshot from 2023-09-01 10-20-08

@cooper-joe cooper-joe marked this pull request as draft December 15, 2023 14:26
@cooper-joe cooper-joe marked this pull request as ready for review December 18, 2023 12:05
@martinkrulltott martinkrulltott changed the title fix: dimension list design fix: dimension list design (DHIS2-16270) Dec 21, 2023
@martinkrulltott martinkrulltott merged commit e3931e6 into master May 14, 2024
2 checks passed
@martinkrulltott martinkrulltott deleted the dimension-list-design branch May 14, 2024 09:37
dhis2-bot added a commit that referenced this pull request May 14, 2024
## [26.6.10](v26.6.9...v26.6.10) (2024-05-14)

### Bug Fixes

* dimension list design (DHIS2-16270) ([#1530](#1530)) ([e3931e6](e3931e6))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 26.6.10 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants