Get version without deprecation warnings #29
Conversation
obonet/__init__.py
Outdated
| else: | ||
| from pkg_resources import DistributionNotFound, get_distribution | ||
|
|
||
| try: | ||
| return str(get_distribution("obonet").version) | ||
| except DistributionNotFound: | ||
| return None |
There was a problem hiding this comment.
Thanks for the contribution!
What do you think about bumping to 3.8 at
Line 31 in fec6a82
Line 57 in fec6a82
obonet/.github/workflows/build.yaml
Line 16 in fec6a82
and then removing the from pkg_resources import DistributionNotFound, get_distribution approach altogether?
There was a problem hiding this comment.
3.7 end of life as of June 27, 2023 and pip should know to install an older release of obonet if using python 3.7
There was a problem hiding this comment.
That's fine with me, I tend to always err on the side of broader compatibility unless there is a meaningful feature being blocked by it, but I think in this case, this would not be a big issue.
There was a problem hiding this comment.
Cool. I'm happy to make the changes after merging this or you can. Let me know which you prefer!
I tend to always err on the side of broader compatibility unless there is a meaningful feature being blocked by it, but I think in this case, this would not be a big issue.
Yes compatibility is good but also making this package as easy to maintain as possible is also good.
There was a problem hiding this comment.
I made the changes, feel free to make further modifications if needed.
|
Release |
The line
from pkg_resources import DistributionNotFound, get_distributionproduces deprecation warnings (see https://setuptools.pypa.io/en/latest/pkg_resources.html). This PR implements a variant for Python 3.8+ that avoids these deprecations.