Skip to content

Commit

Permalink
Load payloads without readonly flag (bytecodealliance#33)
Browse files Browse the repository at this point in the history
* do not set read_only flag when reading payloads

* re-enable cont_resume2 test
  • Loading branch information
frank-emrich authored Jun 9, 2023
1 parent adaf75b commit 14e2a7e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion crates/cranelift/src/func_environ.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2330,7 +2330,7 @@ impl<'module_environment> cranelift_wasm::FuncEnvironment for FuncEnvironment<'m
valtypes: &[WasmType],
base_addr: ir::Value,
) -> Vec<ir::Value> {
let memflags = ir::MemFlags::trusted().with_readonly();
let memflags = ir::MemFlags::trusted();
let mut values = vec![];
if valtypes.len() == 0 {
// OK
Expand Down
4 changes: 2 additions & 2 deletions tests/misc_testsuite/typed-continuations/cont_resume2.wast
Original file line number Diff line number Diff line change
Expand Up @@ -60,5 +60,5 @@
(resume $cont_int_to_int)
))

;; TODO(frank-emrich) This is test is currently broken
;; (assert_return (invoke "f") (i32.const 100))

(assert_return (invoke "f") (i32.const 100))

0 comments on commit 14e2a7e

Please sign in to comment.