Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support authorizer with no identity source specified #1639

Merged

Conversation

frozenbonito
Copy link
Contributor

Description

fix #1638

Motivation and Context

If the authorizer type is REQUEST and its caching is disabled, the identity source is not required.
See #1638 for details.

How Has This Been Tested?

I added no-identity-source-authorizer integration test.

@dnalborczyk
Copy link
Collaborator

dnalborczyk commented Jan 4, 2023

thank you for the PR @frozenbonito !

when I publish your serverless.yml to aws npx serverless deploy and hit the route (with no headers) my response is:

{
  "message": null
}

whereas when I run it locally npx serverless offlin start I get:

{
  "message": "hello"
}

is that expected?

@frozenbonito
Copy link
Contributor Author

@dnalborczyk
Sorry, it seems that package.json was missing.

@frozenbonito frozenbonito force-pushed the fix-empty-identity-source-support branch from e5430e5 to 2bad7f9 Compare January 4, 2023 04:00
@frozenbonito
Copy link
Contributor Author

Fixed.

@cruzj6
Copy link

cruzj6 commented Sep 18, 2023

Will this be merged? Still having this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty identity source support is broken
4 participants